[#757] Emphasize USD values in Writer Stats + Activity Stats#761
[#757] Emphasize USD values in Writer Stats + Activity Stats#761realproject7 merged 2 commits intomainfrom
Conversation
Writer Stats: Donations Received and Royalties Claimed now show USD first (bold) with PLOT amount in muted parentheses. Activity Stats: Trade Vol and Donated boxes now show USD values using plotUsd price, labels simplified to "Trade Vol" and "Donated" (no PLOT). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
T2b APPROVE
Clean swap of USD/PLOT emphasis. Writer Stats correctly show USD bold first with PLOT muted in parentheses. Activity Stats boxes use plotUsd for USD conversion with proper fallback chain (USD > PLOT > dash). Labels simplified as required. No concerns.
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The Writer Stats swap looks fine, but the new Activity Stats fallback path can still show PLOT-denominated numbers under USD-only labels.
Findings
- [medium] When
plotUsdis unavailable, theTrade VolandDonatedboxes fall back to raw PLOT amounts even though the labels no longer indicate PLOT units. That creates misleading output during initial load or price-fetch failure, because the UI now presents unlabeled token amounts where the ticket explicitly asked for USD values.- File:
src/app/profile/[address]/page.tsx:1887 - File:
src/app/profile/[address]/page.tsx:1895 - Suggestion: Render
—untilplotUsdis available, or keep an explicit PLOT unit in both the value and label when falling back.
- File:
Decision
Requesting changes because the current fallback breaks the intended USD emphasis in Activity Stats and can display the wrong unit semantics to users.
Trade Vol and Donated boxes now show "—" when plotUsd is unavailable, avoiding unlabeled PLOT values since labels no longer include "(PLOT)". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The follow-up commit resolves the remaining Activity Stats issue: Trade Vol and Donated now render USD values when plotUsd is available and show — otherwise, so the simplified labels no longer hide raw PLOT units.
Findings
- None.
Decision
Approving because the Writer Stats and Activity Stats changes now match the requested behavior for issue #757 and the previously reported unit-mismatch is resolved.
2 participants
Summary
plotUsdprice; labels simplified to "Trade Vol" and "Donated" (removed "(PLOT)")Fixes #757
Test plan
npm run buildpasses🤖 Generated with Claude Code